paul-rogers commented on a change in pull request #1599: DRILL-6903:
SchemaBuilder code improvements
URL: https://github.com/apache/drill/pull/1599#discussion_r245888019
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/metadata/RepeatedListBuilder.java
##########
@@ -26,12 +26,15 @@
* here. It would certainly be cleaner to have a single field, with the
* number of dimensions as a property, but that is not how Drill evolved.
*/
-
public class RepeatedListBuilder implements SchemaContainer {
private final SchemaContainer parent;
private final String name;
- private AbstractColumnMetadata child;
+ private ColumnMetadata child;
+
+ public RepeatedListBuilder(String name) {
Review comment:
Here and elsewhere. Since these classes now work in two modes, might be good
to explain that somewhere, especially how to use the class as a standalone
builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
