paul-rogers commented on a change in pull request #1599: DRILL-6903:
SchemaBuilder code improvements
URL: https://github.com/apache/drill/pull/1599#discussion_r245886315
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/model/MetadataProvider.java
##########
@@ -38,17 +37,16 @@
TupleMetadata tuple();
VariantMetadata variant();
- public static class VectorDescrip {
+ class VectorDescrip {
Review comment:
public? Or, if intentionally protected, is handy to declare that so we know
that protected is intentional.
Also, the class changed from static to inner: this means that it must be
created in the context of its outer class, and carries a pointer to the outer
object. Since that was not needed here, the original declaration used "static"
to avoid unnecessary complexity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
