Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join
to skip incoming build duplicates, automatically stop skipping if too few
URL: https://github.com/apache/drill/pull/1606#discussion_r247005964
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinMemoryCalculator.java
##########
@@ -154,6 +151,9 @@ void initialize(boolean firstCycle,
long getInMemorySize();
}
+ interface HashJoinSpillControl {
+ boolean shouldSpill(VectorContainer currentVectorContainer);
Review comment:
The `currentVectorContainer` is used to asses the size of the next batch,
which may vary as the incoming are read. If we make a (reasonable) assumption
that there would be very little variation (as these are join keys), then that
size can be given to the constructor and not passed as an argument to
`shouldSpill()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
