Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join 
to skip incoming build duplicates, automatically stop skipping if too few
URL: https://github.com/apache/drill/pull/1606#discussion_r247727042
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
 ##########
 @@ -1054,12 +1104,15 @@ public IterOutcome executeBuildPhase() throws 
SchemaChangeException {
       }
     }
 
+    int numPartitionsSpilled = 0;
 
 Review comment:
   Done; now using `buildPartitionStatSet.getNumSpilledPartitions()` to get the 
number of spilled partitions (just like the regular Hash Join memory calculator.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to