vdiravka commented on a change in pull request #1602: DRILL-6944: 
UnsupportedOperationException thrown for view over MapR-DB binary table
URL: https://github.com/apache/drill/pull/1602#discussion_r248333066
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/View.java
 ##########
 @@ -127,6 +135,8 @@ public FieldType(String name, RelDataType dataType) {
       default:
         break;
       }
+      keyType = dataType.getKeyType() == null ? null : new FieldType(null, 
dataType.getKeyType());
 
 Review comment:
   Should `keyType` and `valueType` be used with other data types than `MAP`?
   Looks like you can add `MAP` case for swtich statement and place 
initializing of the new fields there.
   _Note_: looks like `precision`, `sacle` and `intervalQualifier` also can be 
used only for specific data types, but if you are not sure, just leave them as 
is.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to