vdiravka commented on a change in pull request #1602: DRILL-6944: UnsupportedOperationException thrown for view over MapR-DB binary table URL: https://github.com/apache/drill/pull/1602#discussion_r248775891
########## File path: exec/java-exec/src/test/resources/view/vw_before_drill_6944.view.drill ########## @@ -0,0 +1,10 @@ +{ + "name" : "vw_before_drill_6944", + "sql" : "SELECT `mapf`\nFROM dfs.`avro/map_string_to_long.avro`", + "fields" : [ { + "name" : "mapf", + "type" : "MAP", + "isNullable" : false + } ], + "workspaceSchemaPath" : [ ] +} Review comment: Good point. I think the proper way to generate it by Drill in the process of creating view. It is a good style to always put the newline as a last character if it is allowed by the file format. For some tools it can be the marker of EOF. Anyway it is pretty minor, since Drill views can be consumed only by Drill. You can leave it as is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services