vdiravka commented on a change in pull request #1602: DRILL-6944:
UnsupportedOperationException thrown for view over MapR-DB binary table
URL: https://github.com/apache/drill/pull/1602#discussion_r248635359
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/View.java
##########
@@ -127,6 +135,8 @@ public FieldType(String name, RelDataType dataType) {
default:
break;
}
+ keyType = dataType.getKeyType() == null ? null : new FieldType(null,
dataType.getKeyType());
+ valueType = dataType.getValueType() == null ? null : new FieldType(null,
dataType.getValueType());
Review comment:
I confused Field Type Name with Filed Name. Filed Name should be used for
`FiledType`. The name of `FiledType` is confusing. Consider renaming
`FiledType` to `Filed`.
Regarding null in constructor, I agree there is no need to store the key,
value names for every internal MAP (it will be not a view, but dataset then).
But I think it will be good to introduce the new constructor without Field
Name.
This constructor will serve for representing internal Fields of complex
Fields (MAP now, maybe List in future) in the View.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
