paul-rogers commented on a change in pull request #1684: DRILL-7073: CREATE SCHEMA command / TupleSchema / ColumnMetadata improvements URL: https://github.com/apache/drill/pull/1684#discussion_r263934458
########## File path: exec/vector/src/main/java/org/apache/drill/exec/record/metadata/ColumnMetadata.java ########## @@ -182,6 +184,10 @@ int expectedElementCount(); + void setFormatValue(String value); Review comment: Perhaps I missed it, but I didn't see unit tests for this new functionality. I heavily rely on unit tests to catch regressions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
