paul-rogers commented on a change in pull request #1684: DRILL-7073: CREATE
SCHEMA command / TupleSchema / ColumnMetadata improvements
URL: https://github.com/apache/drill/pull/1684#discussion_r263932776
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/metadata/PrimitiveColumnMetadata.java
##########
@@ -142,6 +165,87 @@ public void setDefaultValue(Object value) {
@Override
public Object defaultValue() { return defaultValue; }
+ @Override
+ public void setDefaultFromString(String value) {
+ if (value == null) {
+ return;
+ }
+ Object objectValue = null;
+ try {
+ switch (type) {
+ case INT:
+ objectValue = Integer.parseInt(value);
Review comment:
Nit: can't we just say:
defaultValue = Integer.parseInt(value);
return;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
