paul-rogers commented on a change in pull request #1684: DRILL-7073: CREATE
SCHEMA command / TupleSchema / ColumnMetadata improvements
URL: https://github.com/apache/drill/pull/1684#discussion_r263932293
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/metadata/PrimitiveColumnMetadata.java
##########
@@ -142,6 +165,87 @@ public void setDefaultValue(Object value) {
@Override
public Object defaultValue() { return defaultValue; }
+ @Override
+ public void setDefaultFromString(String value) {
Review comment:
This is such a handy operation that you might want to split it into two:
Object valueFromString(String value)
And your current function, which would call the above function internally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
