arina-ielchiieva commented on a change in pull request #1726: DRILL-7143: 
Support default value for empty columns
URL: https://github.com/apache/drill/pull/1726#discussion_r271268972
 
 

 ##########
 File path: 
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/convert/AbstractWriteConverter.java
 ##########
 @@ -68,6 +68,11 @@ public ColumnMetadata schema() {
     return baseWriter.schema();
   }
 
+  @Override
+  public void setDefaultValue(Object value) {
+    throw new IllegalStateException("Cannot set a default value through a 
shim; types conflict.");
 
 Review comment:
   Should we include `value` in the error message?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to