arina-ielchiieva commented on a change in pull request #1726: DRILL-7143:
Support default value for empty columns
URL: https://github.com/apache/drill/pull/1726#discussion_r272136449
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/convert/ConvertStringToBoolean.java
##########
@@ -37,7 +37,11 @@ public void setString(final String value) {
baseWriter.setNull();
} else {
try {
- baseWriter.setInt(Boolean.parseBoolean(value) ? 1 : 0);
+ int intValue = Boolean.parseBoolean(value) ? 1 : 0;
Review comment:
Consider using `BooleanType.get` instead, it will cover all cases with
numeric and literal values. Though we might need to move `BooleanType` to
common module so it will be visible in vector one.
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/expr/BooleanType.java#L70
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
