arina-ielchiieva commented on a change in pull request #1726: DRILL-7143:
Support default value for empty columns
URL: https://github.com/apache/drill/pull/1726#discussion_r271265638
##########
File path: common/src/main/java/org/apache/drill/common/types/Types.java
##########
@@ -463,23 +462,29 @@ public static boolean usesHolderForGet(final MajorType
type) {
default:
return true;
}
-
}
public static boolean isFixedWidthType(final MajorType type) {
- switch(type.getMinorType()) {
+ return isFixedWidthType(type.getMinorType());
+ }
+
+ public static boolean isFixedWidthType(final MinorType type) {
+ return ! isVarWidthType(type);
+ }
+
+ public static boolean isVarWidthType(final MinorType type) {
+ switch(type) {
Review comment:
```suggestion
switch (type) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
