ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop
vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r308153779
##########
File path:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
##########
@@ -368,8 +368,13 @@ public static MajorType
getMajorTypeFromHiveTypeInfo(final TypeInfo typeInfo, fi
return typeBuilder.build();
}
- case LIST:
case MAP:
+ return MajorType.newBuilder()
Review comment:
I think this code here is not necessary. This util method still here just
for selection of partition columns vectors, and Hive doesn't partition data
over complex types. I believe it would be good just to rename the method for
clarity in the PR. Later I would like to get rid of the method and fill
partition vectors method and use same approach (factory + Hive writers), like
with regular columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
