ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop
vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r308161746
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/TypedFieldId.java
##########
@@ -188,6 +200,11 @@ public Builder intermediateType(MajorType
intermediateType) {
return this;
}
+ public Builder addMajorType(int index, MajorType type) {
Review comment:
please name int param consistently, for ```isMap``` method, name was
```level``` and here it is ```index```.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
