ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop
vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r317156849
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
##########
@@ -238,6 +238,8 @@ private boolean isColMinorTypeValid(MaterializedField mf)
throws UnsupportedOper
mTypeStr = "LIST";
} else if (mf.getType().getMinorType() == TypeProtos.MinorType.MAP) {
mTypeStr = "MAP";
+ } else if (mf.getType().getMinorType() == TypeProtos.MinorType.DICT) {
Review comment:
The enclosing method may be rewritten to :
```java
private boolean isColMinorTypeValid(MaterializedField mf) {
switch (mf.getType().getMinorType()) {
case GENERIC_OBJECT:
case LATE:
case LIST:
case MAP:
case DICT:
case UNION:
return false;
default:
return true;
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
