paul-rogers commented on a change in pull request #1843: DRILL-7350: Move 
RowSet related classes from test folder

 File path: 
 @@ -15,37 +15,27 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
-package org.apache.drill.test.rowSet;
+package org.apache.drill.exec.physical.rowSet;
 import org.apache.drill.exec.record.RecordBatchSizer;
 import org.apache.drill.exec.physical.rowSet.model.ReaderIndex;
 import org.apache.drill.exec.physical.rowSet.model.single.BaseReaderBuilder;
 import org.apache.drill.exec.record.VectorContainer;
 import org.apache.drill.exec.record.metadata.TupleMetadata;
-import org.apache.drill.test.rowSet.RowSet.SingleRowSet;
+import org.apache.drill.exec.physical.rowSet.RowSet.SingleRowSet;
  * Base class for row sets backed by a single record batch.
 public abstract class AbstractSingleRowSet extends AbstractRowSet implements 
SingleRowSet {
-  public static class RowSetReaderBuilder extends BaseReaderBuilder {
-    public RowSetReader buildReader(AbstractSingleRowSet rowSet, ReaderIndex 
rowIndex) {
-      TupleMetadata schema = rowSet.schema();
-      return new RowSetReaderImpl(schema, rowIndex,
-          buildContainerChildren(rowSet.container(),
-          new MetadataRetrieval(schema)));
-    }
-  }
-  public AbstractSingleRowSet(AbstractSingleRowSet rowSet) {
+  protected AbstractSingleRowSet(AbstractSingleRowSet rowSet) {
 Review comment:
   Why remove nested classes? These are perfectly normal part of Java that 
allows small, single-purpose classes to be associated with the one and only 
class that uses them. Again, if we want to change the Drill style guidelines, 
let's have the discussion on dev list first.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to