paul-rogers commented on a change in pull request #1843: DRILL-7350: Move 
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314780985
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetWriterImpl.java
 ##########
 @@ -129,7 +129,7 @@ public RowSetWriter addRow(Object...values) {
 
   @Override
   public RowSetWriter addSingleCol(Object value) {
-    return addRow(new Object[] {value});
+    return addRow(value);
 
 Review comment:
   While this would seem to be true, it won't work for the case of a map:
   
   addRow(new Object[]{"foo", 10})
   
   Is the above two column values, or a single column that happens to be an 
object?
   
   There is actually no need to debate this, however. Without this feature, 
some unit tests will fail. (I know that because I added this method directly in 
response to those test failures...)
   
   Still, if you can get those tests to pass, even with the map value 
ambiguity, then my concern will be addressed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to