ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop
vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r318115592
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/metadata/FileMetadataCollector.java
##########
@@ -240,20 +240,23 @@ private void addColumnMetadata(String[] columnName,
private static class ColTypeInfo {
OriginalType originalType;
+ List<OriginalType> parentTypes;
int precision;
int scale;
int repetitionLevel;
int definitionLevel;
- ColTypeInfo(OriginalType originalType, int precision, int scale, int
repetitionLevel, int definitionLevel) {
+ ColTypeInfo(OriginalType originalType, List<OriginalType> parentTypes,
+ int precision, int scale, int repetitionLevel, int
definitionLevel) {
this.originalType = originalType;
+ this.parentTypes = parentTypes;
this.precision = precision;
this.scale = scale;
this.repetitionLevel = repetitionLevel;
this.definitionLevel = definitionLevel;
}
- static ColTypeInfo of(MessageType schema, Type type, String[] path, int
depth) {
+ static ColTypeInfo of(MessageType schema, Type type, String[] path, int
depth, List<OriginalType> originalTypes) {
Review comment:
Please use consistent naming. Field and constructor param was named
```parentTypes``` but here ```originalTypes``` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
