ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop
vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r317168767
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/TypedFieldId.java
##########
@@ -56,10 +60,11 @@ public TypedFieldId(MajorType type, boolean isHyper,
int... fieldIds) {
}
public TypedFieldId(MajorType intermediateType, MajorType secondaryFinal,
MajorType finalType, boolean isHyper, PathSegment remainder, int... fieldIds) {
- this(intermediateType, secondaryFinal, finalType, isHyper, false,
remainder, fieldIds);
+ this(intermediateType, secondaryFinal, finalType, isHyper, false,
remainder, new HashMap<>(), fieldIds);
Review comment:
It would be really great to throw away all the telescopic constructors, only
leave one private which accepts only builder instance. And force to use builder
everywhere when new instance is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
