ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop
vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r317146094
##########
File path: common/src/main/java/org/apache/drill/common/types/Types.java
##########
@@ -728,8 +732,10 @@ public static int getScale(MajorType majorType) {
* @return true if type can be used in ORDER BY clause
*/
public static boolean isSortable(MinorType type) {
- // Currently only map and list columns are not sortable.
- return type != MinorType.MAP && type != MinorType.LIST;
+ // Currently only map, list and dict columns are not sortable.
+ return type != MinorType.MAP
Review comment:
Please rewrite method body to:
```java
switch (type) {
case MAP:
case DICT:
case LIST:
return false;
default:
return true;
}
```
Also I suspect that UNION also is not sortable, need to check this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
