paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r347115224
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/TestSchemaBuilder.java
##########
@@ -280,6 +280,40 @@ public void testRepeatedListInRow() {
assertEquals(DataMode.REPEATED, child.mode());
}
+ /**
+ * Tests creating a dict within a row.
+ * Also the basic dict add key and value columns methods.
+ */
+ @Test
+ public void testDictInRow() {
+ TupleMetadata schema = new SchemaBuilder()
+ .addDict("d", MinorType.VARCHAR)
+ .nullableValue(MinorType.FLOAT8)
+ .resumeSchema()
Review comment:
Nit: Indent value structure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
