paul-rogers commented on a change in pull request #1870: DRILL-7359: Add support for DICT type in RowSet Framework URL: https://github.com/apache/drill/pull/1870#discussion_r361567680
########## File path: exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/AbstractKeyAccessor.java ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.vector.accessor; + +import org.joda.time.Instant; +import org.joda.time.LocalDate; +import org.joda.time.LocalTime; +import org.joda.time.Period; + +import java.math.BigDecimal; + +public class AbstractKeyAccessor implements KeyAccessor { + + protected final DictReader dictReader; + protected final ScalarReader keyReader; + + protected AbstractKeyAccessor(DictReader dictReader, ScalarReader keyReader) { + this.dictReader = dictReader; + this.keyReader = keyReader; + } + + @Override + public boolean find(boolean key) { + throw new UnsupportedOperationException(this.getClass().getName() + " does not support boolean key."); Review comment: Nit: ``` throw unsupported("boolean"); ... private UnsupportedOperationException unsupported(String type) { return new UnsupportedOperationException(String.format( "%s does not support a key of type %s.", getClass().getName(), type)); } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
