paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r361565139
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/impl/ContainerState.java
##########
@@ -172,4 +172,8 @@ public void close() {
colState.close();
}
}
+
+ public boolean isDict() {
+ return false;
+ }
Review comment:
Should clients of this class care what kind of container this is? Shouldn't
all DICT-specific code be in the DICT related classes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
