paul-rogers commented on a change in pull request #1870: DRILL-7359: Add support for DICT type in RowSet Framework URL: https://github.com/apache/drill/pull/1870#discussion_r361606350
########## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderDictArray.java ########## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.physical.resultSet.impl; + +import static org.apache.drill.test.rowSet.RowSetUtilities.map; +import static org.apache.drill.test.rowSet.RowSetUtilities.objArray; +import static org.apache.drill.test.rowSet.RowSetUtilities.strArray; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertSame; +import static org.junit.Assert.assertTrue; + +import java.util.Iterator; + +import org.apache.drill.categories.RowSetTests; +import org.apache.drill.common.types.TypeProtos.MinorType; +import org.apache.drill.exec.physical.resultSet.ResultSetLoader; +import org.apache.drill.exec.physical.resultSet.RowSetLoader; +import org.apache.drill.exec.record.MaterializedField; +import org.apache.drill.exec.record.metadata.SchemaBuilder; +import org.apache.drill.exec.record.metadata.TupleMetadata; +import org.apache.drill.exec.vector.accessor.DictWriter; +import org.apache.drill.exec.vector.complex.DictVector; +import org.apache.drill.exec.vector.complex.RepeatedDictVector; +import org.apache.drill.test.SubOperatorTest; +import org.apache.drill.exec.physical.rowSet.RowSet; +import org.apache.drill.exec.physical.rowSet.RowSet.SingleRowSet; +import org.apache.drill.test.rowSet.RowSetUtilities; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +/** + * Test dict array support in the result set loader. + */ +@Category(RowSetTests.class) +public class TestResultSetLoaderDictArray extends SubOperatorTest { Review comment: Thanks for the excellent and complete tests. The one addition I might suggest is to add an overflow test for both the array and non-array cases. Basically, you want to make the vector exceed 16 GB. I do this by using big strings (~ 512 bytes in size.) Use an odd size: 523 or some such, to that overflow occurs in an other than a even row count. Then, use big keys to trigger overflow of the key vector. Check the resulting output batches. Then, repeat for the value vector. Overflow is the most complex part of the result set loader. If you look at examples for VarChar fields and arrays, you might see what was done before. (Avoid the "Torture" test: that one is very complex because it tries to set up near-random, yet predictable, overflow patterns.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
