arina-ielchiieva commented on a change in pull request #1914: DRILL-7458: Base
framework for storage plugins
URL: https://github.com/apache/drill/pull/1914#discussion_r369428346
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/base/DummyGroupScan.java
##########
@@ -97,36 +100,33 @@ public RelOp acceptFilter(RelOp relOp) {
// Pretend that "id" is a special integer column. Can handle
// equality only.
-
if (relOp.colName.contentEquals("id")) {
// To allow easier testing, require exact type match: no
// attempt at type conversion here.
-
if (relOp.op != RelOp.Op.EQ || relOp.value.type != MinorType.INT) {
return null;
}
return relOp;
}
- // All other columns apply only if projected
-
- if (!FILTER_COLS.contains(relOp.colName)) {
+ // "allTypes" table filters everything. All other tables
+ // only project a fixed set of columns. Simulates a plugin
+ // which can project only some columns.
+ if (!scanSpec.tableName.equals("allTypes") &&
!FILTER_COLS.contains(relOp.colName)) {
Review comment:
Nit: usually constant goes first to avoid NPE `"allTypes".equals(...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
