arina-ielchiieva commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369433503
########## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/base/TestFilterPushDown.java ########## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.base; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.fail; + +import java.io.BufferedReader; +import java.io.File; +import java.io.FileNotFoundException; +import java.io.FileReader; +import java.io.IOException; +import java.io.PrintWriter; +import java.io.Reader; +import java.io.StringReader; +import java.net.URL; + +import org.apache.drill.exec.store.StoragePluginRegistry; +import org.apache.drill.test.ClusterFixtureBuilder; +import org.apache.drill.test.ClusterTest; +import org.junit.BeforeClass; +import org.junit.Ignore; +import org.junit.Test; + +/** + * Tests for the Filter push-down helper classes as part of the + * "Base" storage plugin to be used for add-on plugins. Uses a + * "test mule" ("Dummy") plug-in which goes through the paces of + * planning push down, but then glosses over the details at run time. + * The focus here are plans: the tests plan a query then compare the + * actual plan against and expected ("golden") plan. + * <p> + * If comparison fails, the tests print the actual plan to the console. + * Use this, when adding new tests, to create the initial "golden" file. + * Also, on failures, actual output is written to + * <code>/tmp/drill/store/base</code>. You can use your IDE to compare + * the actual and golden files to understand changes. If the changes + * are expected, use that same IDE to copy changes from the actual + * to the golden file. + * <p> + * The JSON properties of the serialized classes are all controlled + * to have a fixed order to ensure that files compare across test + * runs. + */ +public class TestFilterPushDown extends ClusterTest { + + private static final String BASE_SQL = "SELECT a, b FROM dummy.myTable"; + private static final String BASE_WHERE = BASE_SQL + " WHERE "; + + @BeforeClass + public static void setup() throws Exception { + ClusterFixtureBuilder builder = new ClusterFixtureBuilder(dirTestWatcher); + startCluster(builder); + + StoragePluginRegistry pluginRegistry = cluster.drillbit().getContext().getStorage(); + DummyStoragePluginConfig config = + new DummyStoragePluginConfig(true, true, false); + pluginRegistry.createOrUpdate("dummy", config, true); Review comment: It is used in JDBC plugin tests, please leave only one verions than yours or previous one, I don't think we don't need two. https://github.com/apache/drill/blob/465fae6b9dcea9e02a4bfb71d9a3b9d4b99e169d/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithH2IT.java#L68 https://github.com/apache/drill/blob/465fae6b9dcea9e02a4bfb71d9a3b9d4b99e169d/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMySQLIT.java#L85 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
