arina-ielchiieva commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369426397
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/filter/ConstantHolder.java ########## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.base.filter; + +import org.apache.drill.common.types.TypeProtos.MinorType; +import org.apache.drill.exec.store.base.PlanStringBuilder; +import org.joda.time.DateTimeZone; +import org.joda.time.format.DateTimeFormatter; +import org.joda.time.format.ISODateTimeFormat; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonPropertyOrder; + +/** + * Description of a constant argument of an expression. + */ + +@JsonPropertyOrder({"type", "value"}) +public class ConstantHolder { + @JsonProperty("type") + public final MinorType type; + @JsonProperty("value") + public final Object value; + + @JsonCreator + public ConstantHolder( + @JsonProperty("type") MinorType type, + @JsonProperty("value") Object value) { + this.type = type; + this.value = value; + } + + public ConstantHolder convertTo(MinorType toType) { + if (type == toType) { + return this; + } + switch (toType) { + case INT: + return toInt(); + case BIGINT: + return toBigInt(); + case TIMESTAMP: + return toTimestamp(null); + case VARCHAR: + return toVarChar(); + default: + throw conversionError(toType); + } + } + + public ConstantHolder normalize(MinorType toType) { + try { + return convertTo(toType); + } catch (Throwable e) { + return null; Review comment: What is others need to push down more types? What they should do? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
