paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata Queries Fail with Large Files URL: https://github.com/apache/drill/pull/1978#discussion_r380487624
########## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ########## @@ -92,6 +93,20 @@ private static final String LONG_COLUMN_NAME = "long_data"; + private static final String DATA_SIZE_COLUMN_NAME = "data_size"; + + private static final String ELEMENT_COUNT_NAME = "element_count"; + + private static final String IS_TIMESTAMP_NAME = "is_timestamp"; Review comment: The two `is` columns appear mutually exclusive. I wonder, does it make sense to define an `extended_type` column if `data_type` is the Drill type? That is, for most columns, `extended_type` would be null. For these two it would be, say `TIMESTAMP` or `TIME_DURATION`. Though, truth be told, Drill has `TIMESTAMP` and `INTERVAL` columns, so if we mapped the HDF5 type to these Drill types, we would not need the extended type (or these two Boolean columns). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
