cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r380915865
##########
File path:
contrib/format-hdf5/src/test/java/org/apache/drill/exec/store/hdf5/TestHDF5Format.java
##########
@@ -98,9 +98,9 @@ public void testStarQuery() throws Exception {
testBuilder()
.sqlQuery("SELECT * FROM dfs.`hdf5/dset.h5`")
- .unOrdered()
- .baselineColumns("path", "data_type", "file_name", "int_data")
- .baselineValues("/dset", "DATASET", "dset.h5", finalList)
+ .ordered()
Review comment:
@paul-rogers
Thanks as always for your responses. I don't know that I'd use this plugin
as an example of much, just because I don't think there are many other data
formats like it. (Maybe I'm wrong about that).
I do think we should look at the LTSV and other EVF conversions and make
incremental improvements to an "Easy EVF" interface that will reduce cut/paste
code in format plugins and make them easier to write.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
