paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata Queries Fail with Large Files URL: https://github.com/apache/drill/pull/1978#discussion_r380885317
########## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ########## @@ -92,6 +93,20 @@ private static final String LONG_COLUMN_NAME = "long_data"; + private static final String DATA_SIZE_COLUMN_NAME = "data_size"; + + private static final String ELEMENT_COUNT_NAME = "element_count"; + + private static final String IS_TIMESTAMP_NAME = "is_timestamp"; Review comment: @cgivre, maybe just add the `extended_type` column (or `hdf5_type`) to tell the user the actual data type, leaving the `data_type` to provide the converted Drill type. This will work whether the code actually supports time/interval conversion or not. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
