paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r380982462
##########
File path:
contrib/format-hdf5/src/test/java/org/apache/drill/exec/store/hdf5/TestHDF5Format.java
##########
@@ -98,9 +98,9 @@ public void testStarQuery() throws Exception {
testBuilder()
.sqlQuery("SELECT * FROM dfs.`hdf5/dset.h5`")
- .unOrdered()
- .baselineColumns("path", "data_type", "file_name", "int_data")
- .baselineValues("/dset", "DATASET", "dset.h5", finalList)
+ .ordered()
Review comment:
Agreed. The point is not so much to change what you have here. Rather, it is
to learn what more Drill should provide. Some other random examples of nested
schemas are 1) REST calls, 2) Zip archives, 3) Iceberg files, 4) the JDBC
storage plugin.
I'm sure these are all done either not at all (Zip, Iceberg) or via ad-hoc
code (JDBC). The lesson is that Drill probably needs a way to support nested
schemas; not all data sources are Parquet or JSON files on HDFS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
