dobesv commented on a change in pull request #1997: DRILL-7604: Allow session
options to be set in HTTP queries
URL: https://github.com/apache/drill/pull/1997#discussion_r384708343
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java
##########
@@ -110,6 +118,48 @@ public Viewable submitQuery(@FormParam("query") String
query,
}
}
+ @Nonnull
+ private Map<String, Object> readOptionsFromForm(Form form) {
+ Map<String, Object> options = new HashMap<String, Object>();
+ SessionOptionManager sessionOptionManager =
webUserConnection.getSession().getOptions();
+ for (Map.Entry<String, List<String>> pair : form.asMap().entrySet()) {
+ String name = pair.getKey();
+ OptionDefinition definition =
sessionOptionManager.getOptionDefinition(name);
+ if (definition != null) {
+ String valueStr = pair.getValue().get(0);
+ if (!valueStr.isEmpty()) {
+ try {
+ Object value = null;
+ switch (definition.getValidator().getKind()) {
Review comment:
When I parse the form the inputs are all strings, but when the input comes
from JSON they can be mixed types. I think it is better this way despite the
apparent duplication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
