dobesv commented on a change in pull request #1997: DRILL-7604: Allow session
options to be set in HTTP queries
URL: https://github.com/apache/drill/pull/1997#discussion_r384709874
##########
File path: exec/java-exec/src/main/resources/rest/query/query.ftl
##########
@@ -83,6 +83,16 @@
Submit
</button>
<input type="checkbox" name="forceLimit" value="limit" <#if
model.isAutoLimitEnabled()>checked</#if>> Limit results to <input type="text"
id="autoLimit" name="autoLimit" min="0"
value="${model.getDefaultRowsAutoLimited()?c}" size="6" pattern="[0-9]*"> rows
<span class="glyphicon glyphicon-info-sign" title="Limits the number of records
retrieved in the query. Ignored if query has a limit already"
style="cursor:pointer"></span>
+ <label> Store Format
Review comment:
This should work for 99% of users, I think. If they select something that
isn't supported they will just get an error. The alternative would be a
free-form text input, which would still just report an error if you input an
unsupported value. This drop-down can be updated over time to include all
known supported output formats of all the plugins and the user can more easily
pick a format using a drop-down than a text input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
