arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow
session options to be set in HTTP queries
URL: https://github.com/apache/drill/pull/1997#discussion_r384398220
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java
##########
@@ -48,13 +51,21 @@
private final String queryType;
private final int autoLimitRowCount;
+ @Nullable
+ private final Map<String, Object> options;
+
private static MemoryMXBean memMXBean = ManagementFactory.getMemoryMXBean();
@JsonCreator
- public QueryWrapper(@JsonProperty("query") String query,
@JsonProperty("queryType") String queryType, @JsonProperty("autoLimit") String
autoLimit) {
+ public QueryWrapper(
+ @JsonProperty("query") String query,
+ @Nullable @JsonProperty("queryType") String queryType,
Review comment:
Please remove nullable annotation, `javax.annotation` is a separate
dependency and it is not built in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
