paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392610951
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java
##########
@@ -90,17 +95,14 @@ public EasyGroupScan(
@JsonProperty("selectionRoot") Path selectionRoot,
@JsonProperty("schema") TupleMetadata schema
) throws IOException {
- super(ImpersonationUtil.resolveUserName(userName));
+ super(ImpersonationUtil.resolveUserName(userName), columns,
ValueExpressions.BooleanExpression.TRUE);
this.selection = FileSelection.create(null, files, selectionRoot);
this.formatPlugin = engineRegistry.resolveFormat(storageConfig,
formatConfig, EasyFormatPlugin.class);
this.columns = columns == null ? ALL_COLUMNS : columns;
this.selectionRoot = selectionRoot;
- SimpleFileTableMetadataProviderBuilder builder =
- (SimpleFileTableMetadataProviderBuilder)
- new FileSystemMetadataProviderManager()
-
.builder(MetadataProviderManager.MetadataProviderKind.SCHEMA_STATS_ONLY);
- this.metadataProvider = builder.withLocation(selection.getSelectionRoot())
+ this.metadataProvider = defaultTableMetadataProviderBuilder(new
FileSystemMetadataProviderManager())
Review comment:
Will this load data from the metastore on each query? Or, is there some
caching going on behind the scenes? If caching, is the cache global or tied to,
say, the `DrillbitContext`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
