paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392611388
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java
##########
@@ -333,21 +338,73 @@ public boolean canPushdownProjects(List<SchemaPath>
columns) {
}
@JsonProperty
+ @JsonIgnore(value = false)
Review comment:
Odd. The
[Javadoc](https://fasterxml.github.io/jackson-annotations/javadoc/2.5/com/fasterxml/jackson/annotation/JsonIgnore.html)
says that `value = false` means that this `@JsonIgnore` is not active, meaning
it acts as if it is not present. My guess is that the intent of the flag was to
allow compile time constants that conditionally include/remove certain
attributes.
What are we trying to do here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
