paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392610791
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java
##########
@@ -387,15 +386,10 @@ protected void initScanBuilder(FileScanBuilder builder,
EasySubScan scan) {
// Additional error context to identify this plugin
builder.errorContext(
- new CustomErrorContext() {
- @Override
- public void addContext(UserException.Builder builder) {
- builder.addContext("Format plugin:", easyConfig.defaultName);
- builder.addContext("Format plugin:",
- EasyFormatPlugin.this.getClass().getSimpleName());
- builder.addContext("Plugin config name:", getName());
- }
- });
+ currentBuilder -> currentBuilder
+ .addContext("Format plugin:", easyConfig.defaultName)
+ .addContext("Format plugin:",
EasyFormatPlugin.this.getClass().getSimpleName())
+ .addContext("Plugin config name:", getName()));
Review comment:
Nice. If you are changing this, please remove the colons. `UserException`
will now insert them automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
