vvysotskyi commented on a change in pull request #2310:
URL: https://github.com/apache/drill/pull/2310#discussion_r724270936
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/QueryQueue.java
##########
@@ -42,8 +42,6 @@
/**
* Release a query lease obtained from {@link #queue(QueryId, double))}.
* Should be called by the per-query resource manager.
- *
- * @param lease the lease to be released.
*/
void release();
Review comment:
There are two methods related to this, but they both are private in
`EmbeddedQueryQueue` and `DistributedQueryQueue`. I think it will be fine to
use code instead of link there to avoid error.
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/QueryQueue.java
##########
@@ -42,8 +42,6 @@
/**
* Release a query lease obtained from {@link #queue(QueryId, double))}.
* Should be called by the per-query resource manager.
- *
- * @param lease the lease to be released.
*/
void release();
Review comment:
Please replace {@link with {@code
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/QueryQueue.java
##########
@@ -42,8 +42,6 @@
/**
* Release a query lease obtained from {@link #queue(QueryId, double))}.
* Should be called by the per-query resource manager.
- *
- * @param lease the lease to be released.
*/
void release();
Review comment:
Please replace {@ link with {@ code
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/QueryQueue.java
##########
@@ -42,8 +42,6 @@
/**
* Release a query lease obtained from {@link #queue(QueryId, double))}.
* Should be called by the per-query resource manager.
- *
- * @param lease the lease to be released.
*/
void release();
Review comment:
Please replace `{@link` with `{@code`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
