cgivre commented on a change in pull request #2310:
URL: https://github.com/apache/drill/pull/2310#discussion_r723692447
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumnBulkInput.java
##########
@@ -75,7 +75,7 @@
* CTOR.
* @param parentInst parent object instance
* @param recordsToRead number of records to read
- * @param columnPrecInfo column precision information
+ * @param bulkReaderState
* @throws IOException runtime exception in case of processing error
*/
Review comment:
> This is a comment for lines 94, 290, and 366. There is a typo in the
function name: loadPageIfNeeed(). I would like to fix it but do not want to
mess up any other files as a result. If I change the name in all 3 cases, is it
safe to fix?
You should the `refactor->rename` feature in your IDE. It will rename all
the occurrences of that function name, even those in other files. ;-)
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumnBulkInput.java
##########
@@ -75,7 +75,7 @@
* CTOR.
* @param parentInst parent object instance
* @param recordsToRead number of records to read
- * @param columnPrecInfo column precision information
+ * @param bulkReaderState
* @throws IOException runtime exception in case of processing error
*/
Review comment:
> Also, the DefinitionLevelReader link throws an error on line 684.
Would `DefLevelReaderWrapper` be a proper replacement?
I think so.
##########
File path: logical/src/main/java/org/apache/drill/common/graph/GraphAlgos.java
##########
@@ -69,8 +69,7 @@ private void visit(AdjacencyList<V>.Node n) {
*
* @param graph
* The adjacency list for the DAG.
- * @param sourceNodes
- * List of nodes that
+ * @param reverse
Review comment:
@estherbuchwalter
If you can take care of this and the other empty JavaDoc flagged here, I
think we'll be good to go and we can merge this.
##########
File path: logical/src/main/java/org/apache/drill/common/graph/GraphAlgos.java
##########
@@ -69,8 +69,7 @@ private void visit(AdjacencyList<V>.Node n) {
*
* @param graph
* The adjacency list for the DAG.
- * @param sourceNodes
- * List of nodes that
+ * @param reverse
Review comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
