estherbuchwalter commented on a change in pull request #2310:
URL: https://github.com/apache/drill/pull/2310#discussion_r723687384
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumnBulkInput.java
##########
@@ -75,7 +75,7 @@
* CTOR.
* @param parentInst parent object instance
* @param recordsToRead number of records to read
- * @param columnPrecInfo column precision information
+ * @param bulkReaderState
* @throws IOException runtime exception in case of processing error
*/
Review comment:
This is a comment for lines 94, 290, and 366. There is a typo in the
function name: loadPageIfNeeed(). I would like to fix it but do not want to
mess up any other files as a result. If I change the name in all 3 cases, is it
safe to fix?
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumnBulkInput.java
##########
@@ -75,7 +75,7 @@
* CTOR.
* @param parentInst parent object instance
* @param recordsToRead number of records to read
- * @param columnPrecInfo column precision information
+ * @param bulkReaderState
* @throws IOException runtime exception in case of processing error
*/
Review comment:
Also, the DefinitionLevelReader link throws an error on line 684. Would
'DefLevelReaderWrapper' be a proper replacement?
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumnBulkInput.java
##########
@@ -75,7 +75,7 @@
* CTOR.
* @param parentInst parent object instance
* @param recordsToRead number of records to read
- * @param columnPrecInfo column precision information
+ * @param bulkReaderState
* @throws IOException runtime exception in case of processing error
*/
Review comment:
Also, the DefinitionLevelReader link throws an error on line 684. Would
`DefLevelReaderWrapper` be a proper replacement?
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumnBulkInput.java
##########
@@ -75,7 +75,7 @@
* CTOR.
* @param parentInst parent object instance
* @param recordsToRead number of records to read
- * @param columnPrecInfo column precision information
+ * @param bulkReaderState
* @throws IOException runtime exception in case of processing error
*/
Review comment:
Great, thank you!
##########
File path: logical/src/main/java/org/apache/drill/common/graph/GraphAlgos.java
##########
@@ -69,8 +69,7 @@ private void visit(AdjacencyList<V>.Node n) {
*
* @param graph
* The adjacency list for the DAG.
- * @param sourceNodes
- * List of nodes that
+ * @param reverse
Review comment:
Would this be a proper definition for reverse: 'true if reversed,
otherwise false'?
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/QueryQueue.java
##########
@@ -42,8 +42,6 @@
/**
* Release a query lease obtained from {@link #queue(QueryId, double))}.
* Should be called by the per-query resource manager.
- *
- * @param lease the lease to be released.
*/
void release();
Review comment:
This comment is for line 128. The link '#release(QueueLease)' throws an
error. Does anyone have an idea what the replacement should be?
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/QueryQueue.java
##########
@@ -42,8 +42,6 @@
/**
* Release a query lease obtained from {@link #queue(QueryId, double))}.
* Should be called by the per-query resource manager.
- *
- * @param lease the lease to be released.
*/
void release();
Review comment:
Thank you for checking into this. So, what would you recommend I replace
the link with, or should I just delete the link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
