estherbuchwalter commented on pull request #2461: URL: https://github.com/apache/drill/pull/2461#issuecomment-1042317668
Ok, thank you for the review. I used `VarCharHolders` because that's what had been used for the Math UDFs that I am overloading. Yes, I'll add some unit tests with `null` values. Also, I'm going to include a check for `null` in the functions so that `null` values don't cause crashes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
