estherbuchwalter commented on pull request #2461:
URL: https://github.com/apache/drill/pull/2461#issuecomment-1048154224
To clarify, the purpose of this PR is to make Drill more resilient with
different types of input to Math functions. The goal here is that Drill should
not throw an error, and thereby put a halt on all of the query results, when
one value within a large dataset is a different data type than what the Math
function originally expected. Instead it should either know how to handle the
different data type or return a value that conveys that the input was invalid
(like `null`, `NaN`, etc).
For example, before this PR the following SQL query would send a Drill
error: `SELECT abs('-10')`. However, with this PR, the correct value would be
returned (it would be returned as a Float8Holder).
Also, it seems that this functionality would be consistent with industry
standards. I have tried different types of input to Math functions in MySQL and
Postgres databases and each of them accepts VARCHAR input (although they do
handle it a little differently from each other).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
