estherbuchwalter commented on pull request #2461: URL: https://github.com/apache/drill/pull/2461#issuecomment-1047874548
@paul-rogers, thank you for your question. Please let me know if this explanation satisfies your question. In order to maintain precision, each input is parsed to Java type `DOUBLE` (with a few exceptions). I am working on minimizing, or if possible, completely getting rid of the exceptions. First there is a check to ensure that the input is a valid number (accepting `INT` or `DOUBLE`), and then the input is parsed to a `DOUBLE`. Then, the Math function is performed and the function's output is a `Float8Holder`, except for the `sign()` function where the output is an `IntHolder`. Are you suggesting that it would be better to return a `VARDECIMAL` than a `Float8Holder`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
