cgivre commented on a change in pull request #2485:
URL: https://github.com/apache/drill/pull/2485#discussion_r833240470
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
##########
@@ -81,9 +68,8 @@
* to allow tight control of the size of produced batches (as well
* as to support provided schema.)
*/
-public class TextFormatPlugin extends
EasyFormatPlugin<TextFormatPlugin.TextFormatConfig> {
-
- private final static String PLUGIN_NAME = "text";
+public class TextFormatPlugin extends EasyFormatPlugin<TextFormatConfig> {
+ final static String PLUGIN_NAME = "text";
Review comment:
I wonder if it might make sense to follow the model of some of the other
format readers where if the column headers are not known, it assigns a name of
`field_n` to them. That way you still get columns instead of the columns
array.
My view is that if we change the default, but still allow the users to
revert back with a config change, it's not that big of a deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
