jnturton commented on a change in pull request #2485:
URL: https://github.com/apache/drill/pull/2485#discussion_r833325749
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
##########
@@ -81,9 +68,8 @@
* to allow tight control of the size of produced batches (as well
* as to support provided schema.)
*/
-public class TextFormatPlugin extends
EasyFormatPlugin<TextFormatPlugin.TextFormatConfig> {
-
- private final static String PLUGIN_NAME = "text";
+public class TextFormatPlugin extends EasyFormatPlugin<TextFormatConfig> {
+ final static String PLUGIN_NAME = "text";
Review comment:
@cgivre @paul-rogers the master branch is now rolling towards 2.0. If
we don't take the chance in this cycle to improve user-facing stuff, it's a
long time until the next chance.
I do think we should try to segregate our breaking changes into their own
PRs, and therefore squashed commits, as much as we can so that our ability to
cherry pick back to a 1.20.1 or, god forbid, a 1.21 is maxmimally preserved.
FWIW, I'm +1 for turning `columns[n]` into `column_n` (and I think this
terminolgy is more standard for SQL result sets than `field`), +1 for "text"
becoming "delimited" and +0 for the default value of `extractHeaders`, which is
trivial for users to set for themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
