paul-rogers commented on a change in pull request #2485:
URL: https://github.com/apache/drill/pull/2485#discussion_r833958591
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
##########
@@ -81,9 +68,8 @@
* to allow tight control of the size of produced batches (as well
* as to support provided schema.)
*/
-public class TextFormatPlugin extends
EasyFormatPlugin<TextFormatPlugin.TextFormatConfig> {
-
- private final static String PLUGIN_NAME = "text";
+public class TextFormatPlugin extends EasyFormatPlugin<TextFormatConfig> {
+ final static String PLUGIN_NAME = "text";
Review comment:
On the `field_x` vs `columns[]` issue, that part is possible in the
current code, as an option. There is a "columns" class in EVF that handles the
`columns[]` column. I suspect that a parallel "fields" version could be created
that generates the numbered fields instead of array indexes. An option on the
plugin would choose one or the other for the no-headers case.
In fact, with this approach, the individual `field_n` columns could be
typed, based on first-row type inference: something not possible with
`columns[]`.
Anyone up for giving it a shot? I'd be happy to offer pointers along the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
