leventov commented on a change in pull request #5958: Part 2 of changes for SQL
Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522841
##########
File path: sql/src/main/java/io/druid/sql/calcite/planner/Calcites.java
##########
@@ -107,6 +108,7 @@ public static SchemaPlus createRootSchema(final Schema
druidSchema, final Author
public static String escapeStringLiteral(final String s)
{
+ Preconditions.checkNotNull(s);
if (s == null) {
Review comment:
This check immediately after Preconditions.checkNotNull?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
