leventov commented on a change in pull request #5958: Part 2 of changes for SQL
Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522196
##########
File path: processing/src/main/java/io/druid/query/expression/ExprUtils.java
##########
@@ -73,7 +74,14 @@ public static PeriodGranularity toPeriodGranularity(
} else {
Chronology chronology = timeZone == null ?
ISOChronology.getInstanceUTC() : ISOChronology.getInstance(timeZone);
final Object value = originArg.eval(bindings).value();
- origin = value != null ? new DateTime(value, chronology) : null;
+ if (value instanceof String && StringUtils.isEmpty((String) value)) {
Review comment:
This comment:
https://github.com/apache/incubator-druid/pull/5452#discussion_r200339008 is
not addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
