On Wed, Sep 5, 2018 at 10:03 AM Huxing Zhang <[email protected]> wrote:
> Hi, > > On Tue, Sep 4, 2018 at 9:49 PM Zonghai Shang <[email protected]> wrote: > > > > Hello Dubbo Community, > > > > I think it's time to delete the demo module.Because all the examples are > > maintained here : https://github.com/dubbo/dubbo-samples > > Sometimes I find the demo code very useful when you are working as a > developer on Dubbo. > You can simply start the demo to do some local testing in IDE. > +1 This is a truly requirement. It's convenient for us and uses who want to debug Dubbo. So IMO we can keep this demo in dubbo code base. > > In fact I think remaining an official demo in Dubbo's binary release > is very necessary and important, users can download the release and > start the demo with one shot. > > If the demo has been moved to https://github.com/dubbo/dubbo-samples, > I am not sure it is legal to be included in the binary release, > because it is not Apache code anymore. > > There are other things must be taken into consideration: > * user already get used to the way to start dubbo with existing demo > code, this change may increase the cost for users to getting start. > * All the documentation needs to be updated. > > > > > > yiji > > Best Regards > > > > -- > Best Regards！ > Huxing >
